I'm surely not in a position to review anything, but I was interested
just to see what you have done, so I see your work raises 3 questions
I also would like to know an answer to:
docs/ ?
There are doxygen source code comments, but what about end user
documentation? Where should I expect to find it? How will you group
documentation for this plugin together with other authentication
related plugins and possible non-plugin related authentication
sections in the manual? I'm asking because I'm documenting my plugin
too.
namespaces?
What should we use for namespaces for plugin code? I took example from
a plugin that is recent and written by a Drizzle authority figure:
json_server. It uses this:
namespace drizzle_plugin
{
namespace json_server
{
You use this:
namespace drizzled {
namespace plugin {
And other modules use some other variations, there is no standard as
far as I can see. Should there be a standard? (FWIW, if I had just
picked something myself, I would have used
namespace plugin { namespace plugin_name {
)
System tables?
Drizzle doesn't have a system schema like MySQL has mysql.*. You have
chosen to create a schema called auth and put your table in there.
Wouldn't it be better to have a system schema where all such tables
are located. I propose to call such a schema system.* and thus your
table would be called system.auth. (I have my own need in that I may
need to create system tables for stored procedures and triggers,
although it might be better to store them inside the user's schema
instead...)
henrik
On Mon, Sep 26, 2011 at 4:48 AM, Daniel Nichter <dan...@percona.com> wrote:
> Drizzle developers,
>
> I created and pushed auth_schema for
> https://bugs.launchpad.net/drizzle/+bug/738601. It's simple but functional
> (and tested and documented). Any feedback? I still need to add some code
> comments and credits (e.g. to Eric Day since I took and modified
> verifyMySQLHash from his auth_file plugin). Else, I will propose to merge it
> soon.
>
> Thanks,
>
> Daniel
>
> P.S. "auth_schema" instead of "auth_db" since Drizzle is trying to use the
> term "schema" instead of "database".
> _______________________________________________
> Mailing list: https://launchpad.net/~drizzle-discuss
> Post to : drizzle-discuss@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~drizzle-discuss
> More help : https://help.launchpad.net/ListHelp
>
--
henrik.i...@avoinelama.fi
+358-40-8211286 skype: henrik.ingo irc: hingo
www.openlife.cc
My LinkedIn profile: http://www.linkedin.com/profile/view?id=9522559
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to : drizzle-discuss@lists.launchpad.net
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help : https://help.launchpad.net/ListHelp
