Hi ,

Same thing came to my mind and I asked it from Mr Atwood , but instead of
replying to all I just accidently kept sending direct mails to only him.

My Question is that do we have to write a new test or we should just change
the *.result* and *.test* files as the 'make test' will never pass due to
change in output after the bug fix.

And in case of '*CREATE TABLE t1 SELECT * FROM t1*'

Should the error be like ' *Error 1050** ( HY000): Table 't1' already
exists '
*or again like the old one ' *ERROR 1093 (HY000): You can't specify target
table 't1' for update in FROM clause*  '

Thanx for your response,
Kinaan Khan Sherwani

On Thu, Apr 5, 2012 at 3:31 AM, Mark Atwood <m...@mark.atwood.name> wrote:

> Hello Kinaan!
>
> Thank you for your interest in GSoC and for bug fix.  Have you tested
> it using "make test" on your own machines?
>
> If so, please go to your branch's page on LP at
> https://code.launchpad.net/~mr-sherwani/drizzle/trunk-bug626893 and
> click the "Propose for merging" link, and we will queue it up for
> testing and merging with trunk.
>
> Thanks!
>
> On Wed, Apr 4, 2012 at 1:38 PM, Kinaan Khan Sherwani
> <mr.sherw...@gmail.com> wrote:
> > Hi All ,
> >
> > I am G Soc applicant, want to apply in ' table definition files in an
> innodb
> > table ' idea under the mentor-ship of Mr. Stewart Smith.
> > I have committed a bug fix for bug # 626893 . Link to the diff is given
> > below
> >
> >
> http://bazaar.launchpad.net/~mr-sherwani/drizzle/trunk-bug626893/revision/2540
> >
> > Mr. Smith is probably busy , hence not replying to the emails. It will be
> > helpful if some one can review the bug fix I have committed.
> >
> > Regards,
> > Kinaan Khan Sherwani
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~drizzle-discuss
> > Post to     : drizzle-discuss@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~drizzle-discuss
> > More help   : https://help.launchpad.net/ListHelp
> >
>
_______________________________________________
Mailing list: https://launchpad.net/~drizzle-discuss
Post to     : drizzle-discuss@lists.launchpad.net
Unsubscribe : https://launchpad.net/~drizzle-discuss
More help   : https://help.launchpad.net/ListHelp

Reply via email to