On Mon, 2008-11-03 at 07:40 -0600, Ross Gardler wrote: > On 3 Nov 2008, at 06:03, Oleg Kalnichevski wrote: > > > There are two things in Droids that irk me a little > > > > (1) There are lots of places where output is printed to stdout > > bypassing > > the logging framework. I personally think this is suboptimal. > > I doubt anyone here would disagree, so a patch would be readily > accepted. >
Are we 'commit then review' or 'review than commit'? Oleg > > (2) Retrhrowing exceptions as plain RuntimeException is nasty. I do > > not > > intend to provoke another instance of checked vs unchecked exceptions > > discussion. There are pros and cons to both approaches. However, one > > ought not rethrown exceptions as plain RuntimeException. We should > > derive a subclass of RuntimeException, call it > > DroidsRuntimeException or > > re-throw exceptions as a typed exception that can be differentiated > > from > > other runtime exceptions. > > Some would not agree. > > My suggestion is submit a patch for (1) and a proposal for (2) and let > lazy consensus do its work. > > Ross
