[
https://issues.apache.org/jira/browse/DROIDS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702076#action_12702076
]
Ryan McKinley commented on DROIDS-49:
-------------------------------------
I think adding the constructor is fine -- but I think keeping it final is best.
-----
For renaming, getTaskDate() is is from the core Task interface -- I think it
has such a general name because various Task implementations may use it
differently.
We may want to consider changing it there, but I feel strongly about it.
> Make LinkTask.started non-final, and rename it propertly
> --------------------------------------------------------
>
> Key: DROIDS-49
> URL: https://issues.apache.org/jira/browse/DROIDS-49
> Project: Droids
> Issue Type: Improvement
> Components: core
> Reporter: Mingfai Ma
> Attachments: DROIDS-49.patch
>
>
> started/taskDate should be final, but it caused a problem to me in doing unit
> test that a huge number of LinkTask are to be created with different started
> date
> my suggestion:
> 1. make started non-final
> 2. add a constructor
> by design, the 2nd one is better. but in terms of maintainability, it's
> better not to add too many constructors.
> The HttpCore design has some examples (http header of response?! sth like
> that) that final attributes are not necessarily be made as final/immune. I
> suggest just to make the started field non-final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
