[ https://issues.apache.org/jira/browse/DROIDS-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968912#action_12968912 ]
Paul Rogalinski commented on DROIDS-109: ---------------------------------------- @Fuad: can you design some tests for those issues? I understand that designing (j)unit tests for this kind of problems is very time consuming so a bunch of folders, each representing one test-scenario and a description of the expected outcome, would be just fine to start with. Currently I am working on a different part of droids, but I *will* have to deal with robots.txt pretty soon and I would be more than happy to commit an drop-in replacement for the current implementation addressing those issues. > Several defects in robots exclusion protocol (robots.txt) implementation > ------------------------------------------------------------------------ > > Key: DROIDS-109 > URL: https://issues.apache.org/jira/browse/DROIDS-109 > Project: Droids > Issue Type: Bug > Components: core, norobots > Affects Versions: Graduating from the Incubator > Reporter: Fuad Efendi > Fix For: Graduating from the Incubator > > Original Estimate: 672h > Remaining Estimate: 672h > > 1. Googlebot and many others support query part rules; Droids currently > supports only URI.getPath() (without query part) > 2. %2F represents "/" (slash) character inside a path; it shouldn't be > decoded before applying rule > 3. Double decoding is used by NoRobotClient.isUrlAllowed(URI uri) (method > body; baseURI.getPath(); returns decoded string; then we call another > URLDecoder.decode(path, US_ASCII); > 4. URLDecoder.decode(path, US_ASCII); - UTF-8 must be used! > 5. The longest matching directive path (not including wildcard expansion) > should be the one applied to any page URL > 6. Wildcard characters should be recognized > 7. Sitemaps > 8. Crawl rate > 9. BOM sequence is not removed before processing robots.txt > (http://unicode.org/faq/utf_bom.html, bytes: 0xEF 0xBB 0xBF > and most probably many more defects (Nutch & BIXO haven't done it in-full > yet). I am working on it right now... > Some references: > http://nikitathespider.com/python/rerp/ > http://en.wikipedia.org/wiki/Uniform_Resource_Identifier > http://www.searchtools.com/robots/robots-txt.html > http://en.wikipedia.org/wiki/Robots.txt > Referenced (even by Google!) http://www.robotstxt.org/wc/norobots-rfc.html > seems at least outdated... > Proper reference: http://www.robotstxt.org/norobots-rfc.txt (1996). > We need WIKI page explaining all rules implemented by Droids; hopefully it > will become unofficial standard. > *Update from Google:* > http://code.google.com/web/controlcrawlindex/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.