[
https://issues.apache.org/jira/browse/DROIDS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974917#action_12974917
]
Otis Gospodnetic edited comment on DROIDS-106 at 12/24/10 9:26 AM:
-------------------------------------------------------------------
Thanks Eugen. I looked at the patch. What exactly does this buy Droids? (and
I don't mean this in a bad tone at all!)
Here is an example change:
{code}
- if (ssock == null) {
- throw new IllegalStateException("not running");
- }
+ Preconditions.checkState(ssock != null, "not running" );
{code}
This seems about the same in terms of the amount of code or clarify/readability.
Of course, maybe there are some other ugly bits in Droids that Guava could
improve? I don't know.
was (Author: otis):
Thanks Eugen. I looked at the patch. What exactly does this buy Droids?
(and I don't mean this in a bad tone at all!)
Here is an example change:
- if (ssock == null) {
- throw new IllegalStateException("not running");
- }
+ Preconditions.checkState(ssock != null, "not running" );
This seems about the same in terms of the amount of code or clarify/readability.
Of course, maybe there are some other ugly bits in Droids that Guava could
improve? I don't know.
> Introduce Guava (the former google collections) into the droids project
> -----------------------------------------------------------------------
>
> Key: DROIDS-106
> URL: https://issues.apache.org/jira/browse/DROIDS-106
> Project: Droids
> Issue Type: Wish
> Components: core
> Affects Versions: 0.0.1
> Reporter: Eugen Paraschiv
> Fix For: 0.0.1
>
> Attachments: DROIDS-106.patch
>
>
> Google Guava is becoming a standard extension to the collection framework and
> provides some very useful features (besides the obvious collection work which
> is extensive), such as Preconditions (which would standardize the way
> argument checking is done).
> As far as I know, many other Apache projects use Guava (Mahout is one).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
