I'm still trying to get my head around drools to see which way to go with the RDF stuff, but I've noticed one or two things along the way. The code generally looks great to me, though I have three suggestions all related to dependencies :
1. Drop JDring I'm not sure of the need for JDring in the core - all it seems to be doing is running a background timer thread, which shouldn't be too difficult - any further explanation of Scheduler would be helpful (does it really need to know the time?!). btw, it looks like the packaging has changed in JDring v1.4 (or earlier?) from fr.dyade.jdring.* to com.jalios.jdring.* 2. Abstract Interpreter If the scripting bit in org.drools.semantic.java was abstracted out some more (i.e. having a drools Interpreter interface etc.) then it should be straightforward to add other interpreters, e.g. Python (using Jython). 3. Abstract XML The bits in org.drools.semantic.java.io seem to mix the Java parsing in with the XML parsing, again it might be an idea to abstract the dom4j bits, which should make extension more straightforward, and also make it easier to plug in Xerces or whatever instead (this might also be helpful with the RDF module). I believe dom4j has proper support for the SAX/DOM specs, but I've had some real compatibility nightmares using things that are based on the Crimson and Xerces parsers together (Batik SVG API and Jena RDF API, specifically). Let me know what you reckon, I could make a start on these (if approved), as soon I know I've got the latest source. Cheers, Danny. --- Danny Ayers <stuff> http://www.isacat.net </stuff> Idea maps for the Semantic Web http://www.isacat.net/ideagraph ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ drools-interest mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/drools-interest
