On Thursday 29 May 2008 17:21:45 Frédéric Moulins wrote: > Parsing code of options string comes from OpenSSH.
So who exactly is that code copyright by? Your patch doesn't contain any copyright notices, or record this information in any way that I can see, and it's taking rather large chunks of code. Is this "BSD with advertising clause" code that needs the advertising clause? Also, you might want to read: http://www.chris-lott.org/resources/cstyle/ifdefs.pdf And the section of the old http://www.linuxjournal.com/article/5780 article starting with "No ifdefs in .c Code", about how to move #ifdefs into headers so the functions aren't littered with them. Just a thought... Personally, I tend to have symbols #defined to a constant 0 or 1 depending on whether or not a function is enabled, and then just use if(SYMBOL) as a guard and let the compiler's dead code eliminator take it out for me at compile time (because if(0) {blah;} shouldn't put any code in the resulting .o file with any optimizer worth its salt. Borland C for DOS managed simple dead code elimination 20 years ago...) Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson.
