scp issue in 0.56

[Frank Van Uffelen]

Hello, I think I've found a problem in the scp implementation in 0.56:
lines 233-235 of scp.c say:

#ifdef USE_VFORK
                arg_setup(host, remuser, cmd);
#endif

and IMO it should be

#ifndef USE_VFORK
                arg_setup(host, remuser, cmd);
#endif

which would correspond to the logic in previous releases.  As it is now,
dbclient will complain and show its help because arg_setup is never
executed on systems using a regular fork() call.

Do you agree?

Best regards,


Frank Van Uffelen