This is great. Thanks for taking the initiative on this, Ryan. Regarding the HttpClientBuilderTest issues, couldn't these test cases use `new InetSocketAddress(0)` to get ephemeral ports on localhost instead of hardcoding the IPs? It's probably overkill, but would avoid falling back on a pmd exclusion.
On Fri, Jul 29, 2016 at 10:49 PM, Ryan Kennedy <rcken...@gmail.com> wrote: > I've enabled the Code Climate webhook for dropwizard/dropwizard. From now > on, pull requests will be analyzed with checkstyle and pmd. I've created a > pull request where I messed with the indentation to upset checkstyle and > you can see that Code Climate flagged it: > > https://github.com/dropwizard/dropwizard/pull/1655 > > This will hopefully mean we don't need to be on our toes looking for style > violations (particularly indentation, tabs vs. spaces…things like that). > > I had to make some customizations to the Code Climate configuration > <https://github.com/dropwizard/dropwizard/blob/master/.codeclimate.yml>, > in particular asking it not to scan our docs directory as well as a few > binary format files. Aside from that, I've cribbed someone else's > approximately similar checkstyle configuration > <https://github.com/dropwizard/dropwizard/blob/master/checkstyle.xml> for > us to use. Feel free to make changes to it. > > There's some lingering pmd issues > <https://codeclimate.com/github/dropwizard/dropwizard/issues> that Code > Climate has flagged. They're mostly of the "don't hard code IP address" > variety. I don't know pmd well enough, but I'm hoping there's a way to add > a comment or annotation to let it know it's cool in this case since it's a > unit test and that's just a known value to test against. If I get some time > in the next week or so, I can investigate and do a quick clean up. > > Let me know if you have any questions or concerns. > > Ryan > > -- > You received this message because you are subscribed to the Google Groups > "dropwizard-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to dropwizard-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Evan Meagher -- You received this message because you are subscribed to the Google Groups "dropwizard-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to dropwizard-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
