Patches item #2309977, was opened at 2008-11-18 16:38
Message generated for change (Settings changed) made by blancojose
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=319984&aid=2309977&group_id=19984

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Jose Blanco (blancojose)
Assigned to: Nobody/Anonymous (nobody)
Summary: jhove and virus checking for dspace 151

Initial Comment:
This patch uses JHOVE to provide rough-and-ready format checking by identifying 
that the file/bitstream extension matches formats verifiable by JHOVE. 
(Currently DSpace accepts a deposit’s file extension as gospel, so a user could 
tack a “.txt” extension onto a GIF and DSpace would assign the incorrect format 
to the file based on that incorrect extension.) It also checks the file for the 
presence of viruses.

In order to use this patch you must have jhove and ClamAV installed on your 
system.  The change was made to version 1.5.1 of dspace.

Important notes:

(1) HTML identification has proved unreliable ( by jhove ), so this patch does 
not return accurate results for that file format.
(2) This code does not fully incorporate JHOVE’s validation functions; it only 
verifies that what depositors intended to submit is in fact what they 
submitted. 

Returned messages when an error is detected:

Text in [brackets] is a returned value, ALLCAPS can/should be modified to 
reflect your current installation.

Questionable AIFF, GIF, JPG, PDF, TIF, WAVE, XML

DSPACE could not verify that your file is a valid [file_format_extension]. 
Please check the file format and ".[file_format_extension]" extension.

Questionable TXT

DSPACE found the text file you are trying to upload is neither UTF-8 nor ASCII. 
Please verify that your file is in the format you wanted.

Spaces in filenames ( this is an additional check )

The file name contains spaces; this is not recommended. If possible, please 
replace spaces with underscores: "_".

Virus detected

DSPACE detected a virus in this file. Please repair it and resume the deposit. 
If you need assistance, please contact us: EMAIL_ADDRESS.

To get the patch working:

Add the jhove conf files to 

[dspace]/jhove direcoty

Here are the conf files:

jhove-aiff.conf
jhove-ascii.conf
jhove-gif.conf
jhove-jpeg.conff
jhove-pdf.conf
jhove-tiff.conf
jhove-utf8.conf
jhove-wave.conf
jhove-xml.conf

Also the following files were changed:

dspace-api/src/main/java/org/dspace/submit/step/UploadStep.java
dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/aspect/submission/submit/EditFileStep.java
dspace-jspui/dspace-jspui-api/src/main/java/org/dspace/app/webui/submit/step/JSPUploadStep.java
dspace-api/src/main/java/org/dspace/content/FormatIdentifier.java

dspace/modules/jspui/src/main/webapp/submit/get-file-format.jsp ( locally 
customized )
dspace/modules/jspui/src/main/webapp/submit/upload-error-virus.jsp ( new file - 
placed in locally modified area )


These files are attached with this patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=319984&aid=2309977&group_id=19984

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to