Patches item #1970092, was opened at 2008-05-23 03:57 Message generated for change (Settings changed) made by cjuergen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=319984&aid=1970092&group_id=19984
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Larry Stone (lcs8) Assigned to: Nobody/Anonymous (nobody) Summary: fix bug 1970089, add correct deps to jspui module POM Initial Comment: See bug #1970089 for all the details of what this solves. The diff below fixes the build, although it may be adding too many dependencies or have some subtle deficiency, so someoen who really understands the new build system (if anyone does) ought to look it over. ---------------------------------------------------------------------- Comment By: Mark Diggory (mdiggory) Date: 2008-05-23 14:19 Message: Logged In: YES user_id=208348 Originator: NO Yes I "most certainly" tested it before I commited it on the trunk and branch. ---------------------------------------------------------------------- Comment By: Larry Stone (lcs8) Date: 2008-05-23 06:53 Message: Logged In: YES user_id=1194445 Originator: YES OK, but would you please test it first by building an overlay with ItemTag.java in it, or posting your diffs here so I can try them? "trust but verify"... ---------------------------------------------------------------------- Comment By: Mark Diggory (mdiggory) Date: 2008-05-23 06:15 Message: Logged In: YES user_id=208348 Originator: NO Larry, JSTL and the standard taglib shouldn't be needed, they are gotten from the dspace-jspui-api dependencies, we should only need to add the servlet-api because it is scoped provided to keep it from being added to the wars which get it from the servlet container and do not need to package it. I've added the servlet-api to all the webapp modules. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=319984&aid=1970092&group_id=19984 ------------------------------------------------------------------------------ _______________________________________________ Dspace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-devel
