Bugs item #2541435, was opened at 2009-01-27 12:04 Message generated for change (Settings changed) made by dishimitsu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=119984&aid=2541435&group_id=19984
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: 1.5.1 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Daniel Ishimitsu (dishimitsu) Assigned to: Nobody/Anonymous (nobody) Summary: Monthly statistics skip first and last of month Initial Comment: Adding up the monthly view totals for a given item in /dspace/reports/report-year-month.html files yields less than the aggregate total for the item in the current report-general-year-month-day.html. This appears to be an issue with the logLine.beforeDate and logLine.afterDate functions in LogLine.java as they are used in LogAnalyser.java They return true when the dates are equal. Which forces the function processLogs to skip over the log line in LogAnalyser.java for the startDate and endDate (first and last of month). ---------------------------------------------------------------------- >Comment By: Daniel Ishimitsu (dishimitsu) Date: 2009-03-31 12:27 Message: Hi Stuart, Thanks for the fix. I actually opted to adjust the beforeDate and afterDate functions to be exclusive. Same effect, since it only gets called twice, and the other time doesn't matter if it's inclusive/exclusive. Thanks, ---------------------------------------------------------------------- Comment By: Stuart Lewis (stuartlewis) Date: 2009-03-26 15:55 Message: Hi Daniel Thanks for submitting this bug report. Please could you try the attached file and see if it fixes the issue. (beforeDate and afterDate are inclusive, so if using them to test to see if something falls outside of a date range, then you need to use !afterDate instead of beforeDate, and !beforeDate instead of afterDate). Thanks, Stuart ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=119984&aid=2541435&group_id=19984 ------------------------------------------------------------------------------ _______________________________________________ Dspace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-devel
