XMLUI misses logging UsageEvent on requests fulfilled from the cache (with proposed fix) ----------------------------------------------------------------------------------------
Key: DS-264 URL: http://jira.dspace.org/jira/browse/DS-264 Project: DSpace 1.x Issue Type: Bug Components: XMLUI Affects Versions: 1.5.2, 1.6.0 Environment: MacOSX/java1.5/oracle, 1.5.2 Reporter: Larry Stone Priority: Minor Attachments: ue-diff.txt The calls to generate UsageEvents in the XMLUI are in the addBody() method, which never get called when the request is satisfied out of cocoon's cache. In a quiescent test environment this resulted in only one usage event for each distinct Collection, Community, and Item, no matter whether it was requested by different logged-in users or from different IP addresses. Even in a busy production environment, it would probably miss counting many of the requests for a popular Item. The patch moves UsageEvent calls up to the getValidity method, which also calls the system log that seems to reflect activity accurately. Someone who really knows the XMLUI internals ought to check it over, though. Also, the UsageEvent in CommunityViewer.java was incorrectly identifying the object type as an ITEM; the patch fixes that too. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.dspace.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel