[ 
http://jira.dspace.org/jira/browse/DS-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kim Shepherd updated DS-331:
----------------------------

    Attachment: DS-331_Config_property_mismatch_for_xmlui_locale_action.patch

New patch taking the opposite approach -- ie. fixing dspace.cfg's comments and 
commented-out "default" from xmlui.supportedLocales to xmlui.supported.locales

It might not make sense instantly, because 'supported' is simply a word and not 
a component of XMLUI, but this actually follows naming convention for all other 
XMLUI dspace.cfg properties, and was intended to be the property name by the 
author of DSpaceLocaleAction. I believe the comments in dspace.cfg are a typo, 
not the code.

I'm more than happy to hear objections from Andreas or others, it's a close 
call but I think this is the way to go for now... there's no chance of it 
adversely affecting existing installations, because the 
"xmlui.supportedLocales" was never being read by any locale code anyway.

> Wrong config property used in DSpaceLocaleAction.java
> -----------------------------------------------------
>
>                 Key: DS-331
>                 URL: http://jira.dspace.org/jira/browse/DS-331
>             Project: DSpace 1.x
>          Issue Type: Bug
>          Components: XMLUI
>    Affects Versions: 1.5.2
>            Reporter: Andreas Schwander
>            Priority: Minor
>         Attachments: 
> DS-331_Config_property_mismatch_for_xmlui_locale_action.patch, 
> DSpaceLocaleAction_diffs.txt
>
>
> The DSpaceLocaleValidator() in 
> dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/cocoon/DSpaceLocaleAction.java
>  
> uses ConfigurationManager.getProperty("xmlui.supported.locales") , this has 
> to be ConfigurationManager.getProperty("xmlui.supportedLocales").

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to