[
http://jira.dspace.org/jira/browse/DS-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11061#action_11061
]
Stuart Lewis commented on DS-455:
---------------------------------
[15:06] <stuartlewis> http://jira.dspace.org/jira/browse/DS-455 Remove
dspace/config/log4j.xml
[15:06] <richardrodgers> 0 thought doc could address confusion
[15:07] <tdonohue> I'm unsure on this one...I'd rather have docs around it, and
have it as an option
[15:07] <tdonohue> (since I think some folks use the log4j.xml -- looking at
mdiggory)
[15:07] <mdiggory> problem is that having causes users confusion on which is
being used
[15:07] <stuartlewis> But out the box it is confusing having it there, and
we're unsure of how Java treats the precedence.
[15:07] <mdiggory> not really... at least anymore
[15:08] <stuartlewis> There is nothing stopping users putting it back if they
want. An ant update won't remove it.
[15:08] <mdiggory> dspace.cfg / ConfigurationManager define precidence
[15:08] <mhwood> If we keep the .xml then it needs some small updates to keep
up with .properties, and there are several other log4j.* files that want XML
versions.
[15:09] <richardrodgers> updates OK - why do all have to be alike?
[15:09] <mdiggory> xml version and properties version provide same
capabilities. we should just standardize on one.
[15:09] <mhwood> Hmmm, strictly speaking isn't it log4j's
OptionConverter.selectAndConfigure() that defines precedence?
[15:09] <mdiggory> more work to port all logs to xml version
[15:09] <tdonohue> ok, sounds like majority are +1 on this...do we want to vote
officially :)
[15:10] <mdiggory> Not if you hardcode the intialization the way we do
[15:10] <stuartlewis> Probably should.
[15:10] <stuartlewis> +1 to remove log4j.xml, and document that it can be used
if desired.
[15:10] <mdiggory> +1
[15:10] <mhwood> The code I see just passes log.init.config to
selectAndConfigure, and that looks at the tail of the string to decide what to
do.
[15:10] <mhwood> +1
[15:11] <richardrodgers> wait do you mean remove the file or the handling of it
if present?
[15:11] <mhwood> The file, I thought. Handling looks good.
[15:11] <mdiggory> thats right... our code still decides which is designated
though
[15:11] <stuartlewis> Remove log4j.xml from svn
[15:11] <tdonohue> ok, i'll vote +1...i'm swayed
[15:11] <mhwood> I don't see where our code sees both and picks one.
[15:12] <mdiggory> leave the handling, just remove the file... maybe put a copy
on the wiki or something
[15:12] <tdonohue> DS-455 Summary: +4 in favor
> Remove dspace/config/log4j.xml
> ------------------------------
>
> Key: DS-455
> URL: http://jira.dspace.org/jira/browse/DS-455
> Project: DSpace 1.x
> Issue Type: Task
> Reporter: Stuart Lewis
> Assignee: Mark Wood
> Fix For: 1.6.0
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
