[ 
http://jira.dspace.org/jira/browse/DS-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stuart Lewis updated DS-44:
---------------------------

    Attachment: fix-stat-general.patch.txt

The patch for this bug seems to have broken stat-general. stat-monthly is OK.

I think this is because stat-monthly sets start and end dates, but stat-general 
doesn't (therefore in the code, start and end date are null, and the comparison 
fails). This seems to be a side effect of the fix for this issue.

The attached patch adds a check for null start and end dates.

Please could someone verify that stat-general is broken on trunk, and confirm 
the patch fixes it. Thanks.

> Monthly statistics skip first and last of month - ID: 2541435
> -------------------------------------------------------------
>
>                 Key: DS-44
>                 URL: http://jira.dspace.org/jira/browse/DS-44
>             Project: DSpace 1.x
>          Issue Type: Bug
>    Affects Versions: 1.5.1
>            Reporter: Charles Kiplagat
>            Assignee: Stuart Lewis
>             Fix For: 1.6.0
>
>         Attachments: fix-stat-general.patch.txt
>
>
> Adding up the monthly view totals for a given item in
> /dspace/reports/report-year-month.html files yields less than the aggregate
> total for the item in the current report-general-year-month-day.html.
> This appears to be an issue with the logLine.beforeDate and
> logLine.afterDate functions in LogLine.java as they are used in
> LogAnalyser.java
> They return true when the dates are equal. Which forces the function
> processLogs to skip over the log line in LogAnalyser.java for the startDate
> and endDate (first and last of month).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to