[
http://jira.dspace.org/jira/browse/DS-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrea Bollini updated DS-513:
------------------------------
Attachment: sword-auth-connection-leak.patch
The patch add a catch re-throw block for any public authentication method in
the SWORDAuthenticator class.
If an exception was thrown during the authentication process the first DSpace
context object was not released. In the catch block we make sure that the
context is properly aborted and re-throw the exception. The modification in the
DSpaceSWORDServer are not required but IMHO it is more clear if a dummy
variable has a null value instead of a not fully initialized class (information
hiding on the constructor logic).
I will wait a couple of days before commit the patch to the trunk, suggestions
on more elegant solution are welcome!
> Connection leak in SWORD authentication process
> -----------------------------------------------
>
> Key: DS-513
> URL: http://jira.dspace.org/jira/browse/DS-513
> Project: DSpace 1.x
> Issue Type: Bug
> Components: SWORD
> Affects Versions: 1.5.2, 1.6.0
> Reporter: Andrea Bollini
> Assignee: Andrea Bollini
> Priority: Blocker
> Fix For: 1.6.1
>
> Attachments: sword-auth-connection-leak.patch
>
>
> If the SWORD authentication process fails for any reason the connetion to the
> db is not released to the pool
> A patch will be uploaded shortly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
