[ 
http://jira.dspace.org/jira/browse/DS-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kim Shepherd updated DS-401:
----------------------------

    Attachment: DS-401.patch

Attached patch: diff against branch-1_6_x and also current against trunk @ 4871

This patch makes the following changes

* Adds a getActualMax method to DCDate, for date validation anywhere in the API
* Adds some simple validation to org.dspace.submit.step.DescribeStep's readDate 
method. Sets an error field and does not add the date string to item metadata 
if month or day is out of range.

Note: Error messages during submission mostly assumed a missing value rather 
than an invalid one... JSPUI will not show an error message if the date field 
is not required, though XMLUI will show a default 'required' error message. The 
strings for the messages come from the <required> tags in input-forms.xml
At least the incorrect date is not added to item metadata and the user is given 
a chance to re-enter a valid date, but the error handling isn't perfect. 
Perhaps the default hints text ought to be updated?

> Wrong date issued during submission
> -----------------------------------
>
>                 Key: DS-401
>                 URL: http://jira.dspace.org/jira/browse/DS-401
>             Project: DSpace 1.x
>          Issue Type: Bug
>          Components: JSPUI, XMLUI
>    Affects Versions: 1.6.0
>            Reporter: Claudia Jürgen
>            Assignee: Kim Shepherd
>         Attachments: DS-401.patch
>
>
> During the submission of an item, which has been published before, it is 
> possible to enter an invalid day, e.g.
> month: January
> day: 43
> year: 2009
> This will result in dc.date.issued set to 2009-02-12.
> There should be a validity check or calendar to choose from. The 
> transformation of the date makes fault entries difficult to discover.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.dspace.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to