Bugs item #1451749, was opened at 2006-03-16 16:56
Message generated for change (Settings changed) made by tdonohue
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=119984&aid=1451749&group_id=19984

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Larry Stone (lcs8)
Assigned to: Nobody/Anonymous (nobody)
Summary: MetadataField has inconsistent lifecycle methods

Initial Comment:
In the source as of 16-Mar-06 (pre-1.4), the class
org.dspace.content.MetadataField has lifecycle methods
which are not consistent with all of the other similar
classes in the DSpace core code.

Typically, e.g. in org.dspace.content.BitstreamFormat,
the constructors are all private.  To get 
an instance, your code either calls one of find() 
methods to look up an existing object or create() to
make a new, empty, one.  

MetadataField has a similar "find" interface but the
API to create new fields is unusual.  It exposes its
constructors, and requires the caller to make an
instance, fill it in, and then call the create() method
which connects the instance to a new RDBMS entry.

It isn't broken, but it does make maintenance and
development of new code more difficult since a method
with a familiar name has unexpected behavior.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=119984&aid=1451749&group_id=19984

------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to