On Tue, Aug 03, 2010 at 01:57:41PM +1200, Stuart Lewis wrote: > However, I think we need to be careful in drawing a distinction between the > "ideal / correct" answer, and the position that we are currently in. The > DSpace codebase has code that is over 8 years old, and this is our first > foray into providing automated tests. We must recognise that the environment > that we are working in is not the pure TDD environment that we may strive for.
I will observe that in the trunk, as of a few days ago, we have been
living with over four thousand warnings. 'findbugs' also has quite a
bit to say about DSpace, some of it worth looking at. The code is
good, but far from squeaky-clean.
> Therefore I would caution against trying to move to the "ideal" situation
> immediately. Whilst we should have a plan of how to achieve the ideal,
> perhaps we should move to it in a phased approach over the next release or
> two?
>
> For example, as it stands, if we follow the "correct" route, then until
> someone finds enough time (probably a week or two of effort) to fix up
> DCDate, then we'll be in a position where 'mvn package' will fail. Because
> we're in a position where all users need to run this command, it will
> doubtless cause us support issues.
>
> What I'd prefer is that we perhaps launch with the un-ideal state (tests off
> by default, and DCDate with a broken test). If we have the effort available
> we can setup a CI server to run and report on the tests. Of course, as
> developers we can ensure that we run the tests. If tests for a class such as
> DCDate fail, it will at least highlight any new errors being introduced.
What this amounts to is that testing is released as an *experimental*
feature for us to experience and improve, with "production" use coming
later. Given the amount of code put in before the test harness was
added, that seems like a sensible approach. Those willing to wade
through early problems can benefit from its presence now, yet it won't
get in the way of those who would be overwhelmed by the results.
--
Mark H. Wood, Lead System Programmer mw...@iupui.edu
Balance your desire for bells and whistles with the reality that only a
little more than 2 percent of world population has broadband.
-- Ledford and Tyler, _Google Analytics 2.0_
pgpWl0XAlZk5C.pgp
Description: PGP signature
------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://p.sf.net/sfu/dev2dev-palm
_______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
