AuthorizeManager.isAdmin(Context, DSpaceObject) throws exception when EPerson is null -------------------------------------------------------------------------------------
Key: DS-688 URL: http://jira.dspace.org/jira/browse/DS-688 Project: DSpace 1.x Issue Type: Bug Components: DSpace API Affects Versions: 1.6.2, 1.6.1, 1.6.0, 1.5.2, 1.5.1, 1.5.0 Reporter: Kim Shepherd Assignee: Kim Shepherd Priority: Minor Fix For: 1.7.0 AuthorizeManager.isAdmin(Context, DSpaceObject) doesn't test whether EPerson is null before trying getID(), which causes an exception to be thrown when the user is anonymous. Other isAdmin() methods set or initialize userid to 0 (anonymous) to prevent this. The attached patch brings isAdmin(c, dso) in line with other isAdmin methods, optimises the tests slightly, and fixes some indenting (I think) The attached patch will apply correctly to 1.6.2 and trunk (5378), and has been tested against both builds. A patched 1.6.2 AuthorizeManager.java is also attached in case some users find it easier to simply copy source files in place. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.dspace.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel