[ 
https://jira.duraspace.org/browse/DS-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18412#action_18412
 ] 

Mark H. Wood commented on DS-777:
---------------------------------

I agree:  we can avoid losing possibly-useful policies by renaming them out of 
the "magic" sequences.  Since their names don't relate to existing objects, 
this should not be a big deal.  As you observed, XMLUI will no longer know they 
are magical, but it needs fixing anyway as noted in DS-778.

I thought about making the trailing part of the regex more specific.  That 
would require that we remember it should new "special" group name patterns be 
invented, and I'm not sure it would help a lot.  Leave it alone for now and 
revise when we clearly see a need?

> PackageUtils.translateGroupNameForExport returns null unexpectedly
> ------------------------------------------------------------------
>
>                 Key: DS-777
>                 URL: https://jira.duraspace.org/browse/DS-777
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API
>    Affects Versions: 1.7.0
>            Reporter: Mark H. Wood
>            Assignee: Tim Donohue
>         Attachments: METSRightsCrosswalk-updated.patch
>
>
> We have a Community with a ResourcePolicy referring to Group 
> COLLECTION_22_SUBMITTER, which seems to have been hand-created since the 
> automatic naming would have yielded COLLECTION_number_SUBMIT.  There is no 
> Collection with ID 22, so PackageUtils.translateGroupNameForExport() returns 
> null, and we wind up with <rights:UserName USERTYPE="GROUP" /> which causes a 
> CrosswalkInternalException on ingestion.
> I think that, for a Group named type_id_whatever, if we cannot find an object 
> of the given type with the given id, then we should consider the input not a 
> match to the generated-name pattern and return the unaltered name.  We should 
> *never* return null or a zero-length
> String; we should *always* return either the unaltered input or a correct 
> translation.
> Is there a reason for returning null here that I haven't seen?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Oracle to DB2 Conversion Guide: Learn learn about native support for PL/SQL,
new data types, scalar functions, improved concurrency, built-in packages, 
OCI, SQL*Plus, data movement tools, best practices and more.
http://p.sf.net/sfu/oracle-sfdev2dev 
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to