[ 
https://jira.duraspace.org/browse/DS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18656#action_18656
 ] 

Mark H. Wood commented on DS-642:
---------------------------------

Committed revision 6024 (on trunk).  This internally stores all addresses and 
masks as IPv6 to keep the match logic simple.  Also introduces unit tests to 
org.dspace.authenticate, so far only for IPv6 matching.  Light manual testing 
also done.  Your merciless attacks (on the code :-) are solicited.

> IPAuthentication doesn't work with IPv6 addresses
> -------------------------------------------------
>
>                 Key: DS-642
>                 URL: https://jira.duraspace.org/browse/DS-642
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 
> 1.8.0
>            Reporter: Stuart Lewis
>            Assignee: Mark H. Wood
>
> DSpace's IP authentication class does not cope with IPv6 IP addresses.
> org.dspace.authenticate.IPMatcherException: Malformed IP specification 
> 0:0:0:0:0:0:0:1%0
>       at org.dspace.authenticate.IPMatcher.ipToBytes(IPMatcher.java:173)
>       at org.dspace.authenticate.IPMatcher.match(IPMatcher.java:217)
>       at 
> org.dspace.authenticate.IPAuthentication.getSpecialGroups(IPAuthentication.java:210)
>       at 
> org.dspace.authenticate.AuthenticationManager.getSpecialGroups(AuthenticationManager.java:306)
>       at org.dspace.app.webui.util.UIUtil.obtainContext(UIUtil.java:138)
>       at org.apache.jsp.index_jsp._jspService(index_jsp.java:101)
>       at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
>       at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:377)
>       at 
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:313)
>       at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:260)
>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
>       at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
>       at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>       at 
> org.dspace.utils.servlet.DSpaceWebappServletFilter.doFilter(DSpaceWebappServletFilter.java:112)
>       at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
>       at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>       at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
>       at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
>       at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
>       at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
>       at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
>       at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
>       at 
> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:852)
>       at 
> org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588)
>       at 
> org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
>       at java.lang.Thread.run(Thread.java:637)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to