[
https://jira.duraspace.org/browse/DS-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18685#action_18685
]
Tim Donohue commented on DS-659:
--------------------------------
This issue was discussed in the Developer Meeting on Jan 19, 2011.
Overall, this seems like it could be a useful change. However, we believe that
this change likely won't work properly for Oracle as well. It needs analysis
on Oracle, and some more testing to ensure no problems would occur if a new
Collection is added while you are browsing via offset/limit.
Full discussion follows:
[20:01] <tdonohue> Collection.findAll performance issue - offset and limit
improvement : https://jira.duraspace.org/browse/DS-659
[20:02] * richardrodgers ([email protected]) has joined
#duraspace
[20:02] <mhwood> Sounds useful.
[20:02] * tdonohue hi richard, we're starting with a JIRA review. we're looking
at: https://jira.duraspace.org/browse/DS-659
[20:02] <tdonohue> it does sound useful -- I wonder if it could be applied
elsewhere as well
[20:03] <tdonohue> has anyone had time to take a closer look at the code / try
it out?
[20:03] <tdonohue> alternatively, any volunteers to test it out further and do
a small code review of sorts?
[20:03] <grahamtriggs> what happens when an item is added to / deleted from the
collection whilst a client is browsing through the REST interface?
[20:04] <tdonohue> grahamtriggs -- no idea, but that's probably more of a REST
issue, than directly pertaining to DS-659, isn't it?
[20:05] <mhwood> Any Oracle users here? Will there be problems with LIMIT and
OFFSET?
[20:05] <grahamtriggs> tdonohue: except this issue is directly related to REST,
and there isn't necessarily anywhere else where it is / would be used
[20:06] <grahamtriggs> mhwood: and yes, LIMIT / OFFSET do not work in Oracle
[20:06] <mhwood> Patch needs work then.
[20:06] <tdonohue> good point. patch definitely would need to support Oracle as
well.
[20:06] <richardrodgers> Is it the patch or the API?
[20:07] <mhwood> SQL in the patch uses OFFSET and LIMIT.
[20:08] <sandsfish> So patch modifications would need to be completed by
someone with an Oracle instance to test on, yes?
[20:08] <tdonohue> correct -- or anyone willing to install Oracle instance
locally (you can install for free)
[20:09] * mdiggory ([email protected]) has joined
#duraspace
[20:09] <hpottinger> We use Oracle here, can test code
[20:09] <tdonohue> thanks hpottinger, we'd appreciate it. Feel free to add
comments/results to DS-659
[20:09] <sandsfish> ( if by free you mean, $0 + the anguish of dealing with
oracle ;)
[20:10] <tdonohue> Ok, in essence of time, we probably should move on to next
one. If anyone else has comments, please add thoughts/comments to DS-659
> Collection.findAll performance issue - offset and limit improvement
> -------------------------------------------------------------------
>
> Key: DS-659
> URL: https://jira.duraspace.org/browse/DS-659
> Project: DSpace
> Issue Type: Improvement
> Components: DSpace API
> Affects Versions: 1.7.0
> Reporter: Bojan Suzic
> Priority: Trivial
> Attachments: collection.java.add.txt
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> During the REST API development it has been noticed that in some cases
> Collection.findAll may introduce performance issues, e.g. by working on big
> collections.
> For REST based browsing it is inefficient to preload big collection of say
> 20000 items and then return only first 100 items to the user. There are also
> other examples.
> In order to prevent those issues and optimize response I created two
> additional findall functions making possible to use offset and limit clauses
> during collections browsing. Also the simple function for returning number of
> collections in the system is added.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
