[ 
https://jira.duraspace.org/browse/DS-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=19137#action_19137
 ] 

Joseph Rhoads commented on DS-476:
----------------------------------

I did a little bit of digging and I may have founds a couple of places where 
this could be fixed.

For the XMLUI:
In the Class   org.dspace.app.xmlui.aspect.artifactBrowser.CommunityBrowser

The BuildTree function (line 330) sets up the tree structure for 
communities/collections.
On lines 360 and 368 there are inner loops that add communities and collections 
respectively to the tree.
We could make the addition to the tree conditional by placing an
    if(Authorizemanager.authorizeActionBoolean(context, subcommunity, 
Constants.READ)


For JSPUI:
 there are similar loops within CommunityListServlet (lines 58 and 63)
And a similar solution could be put in place.

I think this would do it.
The questions is, will this slow things down too terribly much.
I think this may force a call to the database for each community/collection.  
Would that slow things down much?

-Joseph



> READ action
> -----------
>
>                 Key: DS-476
>                 URL: https://jira.duraspace.org/browse/DS-476
>             Project: DSpace
>          Issue Type: Bug
>          Components: XMLUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0
>         Environment: GNU/Linux Debian Lenny
> ii tomcat6 6.0.20-dfsg1-1 Servlet and JSP engine
> ii sun-java6-jdk 6-12-1 Sun Java(TM) Development Kit (JDK) 6
> ii postgresql 8.3.9-0lenny1 object-relational SQL database (supported 
> version) 
>            Reporter: Fabien COMBERNOUS
>            Priority: Major
>             Fix For: 1.7.1
>
>
> Even without READ action allowed, you can browse inside a collection and a 
> community. You can also read title of documents.
> If you try to read by using the link of the document, you can read it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to