[
https://jira.duraspace.org/browse/DS-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kim Shepherd updated DS-690:
----------------------------
Documentation Status: In Comments (was: Needed)
Attachment: Patch_for_DS-690.patch
Attached patch makes the following changes:
- Fix logger for HandleServlet
- Move firing of UsageEvents for all DSO types to just before JSP is shown, so
that UsageEvents aren't fired on /handle/foo/bar/browse [good? bad?] or
/handle/foo/bar/statistics [definitely good]
- Check extra path in HandleServet for "/statistics", but forward to
"displaystats" -- this allows us to keep naming parity with XMLUI and not
conflict with {dspace.baseURL}/statistics [too confusing?]
- Add extraPathInfo check to HandleServlet's "if item" block so that we can
forward to other servlets (eg. statistics) instead of calling displayItem
- Replaces old ugly GET form in display-item.jsp, community-home.jsp,
collection-home.jsp with a simple link with class 'statisticsLink' for easy
styling
In practice, this is how statistics reports can be viewed for collections,
communities, or items
- The old way still works:
http://dspace.example.com/jspui/displaystats?handle=123456789/12345
- The new way matches XMLUI:
http://dspace.example.com/jspui/handle/123456789/12345/statistics
- Legacy statistics reports can still be accessed via
http://dspace.example.com/jspui/statistics
- Relevent JSPs have been updated -- "View Statistics" form replaced with new
link in the same place (can easily be styled as button if people wish to keep
the same look)
And an important and previously unknown bug has been fixed
- UsageEvents won't be fired unless the object is actually [abou to be] viewed
by the user!
Has been tested, but would appreciate more testing, both in viewing statistics
and in using handles/HandleServlet generally, to ensure I haven't broken
anything.
Will commit to trunk anyway (early and often!) as this is an easy patch to
revert, and having it in trunk makes testing easier for more people.
Documentation:
--
None needed: links in JSPs have been updated, old bookmarks will still work. If
JSPUI's statistics URLs are documented somewhere, then they'd need changing,
that's all.
> Tidy up URL mapping for DisplayStatisticsServlet (JSPUI servlet that handles
> solr statistics)
> ---------------------------------------------------------------------------------------------
>
> Key: DS-690
> URL: https://jira.duraspace.org/browse/DS-690
> Project: DSpace
> Issue Type: Improvement
> Components: JSPUI
> Reporter: Kim Shepherd
> Assignee: Kim Shepherd
> Fix For: 1.8.0
>
> Attachments: Patch_for_DS-690.patch
>
>
> The XMLUI URL mapping for solr statistics is nice and tidy, eg.
> ${contextPath}/handle/123456789/1/statistics
> Whereas the JSPUI URL mapping is not as nice to look at, nor is it as
> functional:
> ${contextPath}/displaystats?handle=123456789/1
> It would help with crawler/sitemap maintenance, path-based authZ, DSO
> resolution, etc. if it was in line with the XMLUI version. My fault. (Mark
> did point this out to me at one stage, too..)
> I'd like to submit a patch for this in time for 1.7, but I wonder whether
> there could be some fallout with researchers, admins, users who have already
> bookmarked older stats pages -- either way, it's better to get the change in
> earlier then later, but I should also make a note in the documentation and
> maybe advertise the change in mailing lists ahead of time.
> I'll put 1.7.0 as a fix version and will work on a patch, but will wait for
> IRC vote/comments before committing code or resolving this issue.
> Cheers,
> Kim
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
