Simplify, internationalize org.dspace.statistics.util.LocationUtils
-------------------------------------------------------------------

                 Key: DS-844
                 URL: https://jira.duraspace.org/browse/DS-844
             Project: DSpace
          Issue Type: Improvement
          Components: DSpace API
    Affects Versions: 1.7.0
            Reporter: Mark H. Wood


Most of the class consists of long one-dimensional String arrays which (a) must 
be kept parallel and (b) only give English names.  Names of countries are 
already in the JRE, in java.util.Locale, where they are also internationalized. 
 For example, to get the French name for China:  new 
Locale("ZH","CN").getDisplayCountry(new Locale("FR","FR"));

LocationUtils.getCountryName() could use 
Locale.getDisplayCountry(request.getLocale()) to replace this private table and 
internationalize its return.

This leaves only the mapping from country to continent and the names of the 
continents.  The mapping should be externalized to e.g. a Properties file or 
Spring map-property injection where it can be updated without recompilation.  
The continents' names should be externalized to localized property bundles such 
as Messages*.properties so they can be internationalized.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.duraspace.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to