I think the patch only fixes an interrupted request (eg requesting /profile when not logged in) in JSPUI.
The original bug requested that no matter what page you're on (eg an Anonymous accessible collection splash page or item page) you go back to that page after login. DS-940 and users at my institution are requesting that this is supported as well. These two similar issues are conflated in this one ticket. The related task (DS-330) discusses session invalidation on login. Isn't that what webui.session.invalidate does? Thanks for looking into this again. Regards, Alex Lemann > -----Original Message----- > From: Tim Donohue [mailto:[email protected]] > Sent: Friday, June 24, 2011 2:11 PM > To: Lemann, Alexander Bernard > Cc: DSpace Developers ([email protected]) > Subject: Re: [Dspace-devel] [DuraSpace JIRA] Commented: (DS-940) Logging > in sends you back to the homepage > > Hi Alex, > > On 6/24/2011 12:29 PM, Lemann, Alexander Bernard wrote: > > DS-570 seems like an important one. It got assigned to a core dev during an > IRC meeting, but the dev unassigned himself from the ticket. When are > orphaned tickets like this reassessed? The committed patch does not > address the user's original concern. > > Orphaned tickets can be reassessed at any time. In fact any ticket can be > reassessed at any time, all that needs to happen is that someone needs to > request reassessment (usually by adding a comment to that issue, which > emails dspace-devel). The initial IRC meeting assessment of a ticket is just > that -- initial thoughts, and an attempt to get it assigned to someone. But, > that need not be the only assessment. > > It looks like based on the ticket comments, here is what has happened: > (1) Peter Dietz volunteered to help fix this issue for JSPUI > (2) The issue was assigned to Peter > (3) Kim Shepherd then actually provided a JSPUI fix. > (4) That JSPUI fix was committed and released in 1.7.0 > (5) Peter unassigned himself as he only volunteered to help with JSPUI. > (6) The ticket remains open as it has not yet been resolved for XMLUI > > So, it sounds like JSPUI should already be fixed in 1.7.x (if it isn't, we > should > reopen that issue). But, XMLUI is still not committed or fixed. However, Pere > Villega kindly has provided an initial patch for XMLUI. Though, it sounds like > it's not 100% working quite yet. > > Therefore, if I'm not mistaken, we need a volunteer developer to help > resolve this once and for all for the XMLUI. But, it looks like JSPUI has a > resolution (again, if anyone feels this isn't the case, please add > comments/details on DS-570). > > > I can't think of a clean way to implement this by passing data through the > session since the non-login URL will need to stick around after a load of: 1. > The chooser page (though I'm not sure of the value of this page& this step > may be bypassed) 2. The login page GET 3. The login page POST. And then, it > will need to be saved before session is reset after login. > > > > Given this, would adding a GET parameter of "next=<path>" to the login > pages be cleaner? Would it be acceptable to throw away GET parameters on > login so that eg searches would break? Or, is there a nice way to encode the > full URI including the parameters? Do we need to worry about URLs getting > too long? > > I think at this point in time any options would be fair game. However, it > might be cleaner to store the URL in the Session (similar to the JSPUI > resolution). The Session should stay "alive" during the entire login process. > I'll > admit, this is really off the top of my head, so I could be missing something > here. > > Essentially, at this point, we need to find a volunteer to create a new patch > for XMLUI (or improve on the existing one). That way we can get this fixed > for 1.8.0. > > If anyone is interested in helping out on this issue, please let us know or > add > a comment or your own thoughts directly to DS-570. > > - Tim > > > >> -----Original Message----- > >> From: Alex Lemann (DuraSpace JIRA) [mailto:[email protected]] > >> Sent: Friday, June 24, 2011 12:49 PM > >> To: [email protected] > >> Subject: [Dspace-devel] [DuraSpace JIRA] Commented: (DS-940) Logging > >> in sends you back to the homepage > >> > >> > >> [ https://jira.duraspace.org/browse/DS- > >> 940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment- > >> tabpanel&focusedCommentId=20778#action_20778 ] > >> > >> Alex Lemann commented on DS-940: > >> -------------------------------- > >> > >> This is a duplicate of DS-570. > >> > >>> Logging in sends you back to the homepage > >>> ----------------------------------------- > >>> > >>> Key: DS-940 > >>> URL: https://jira.duraspace.org/browse/DS-940 > >>> Project: DSpace > >>> Issue Type: Bug > >>> Environment: DSpace 1.7, XMLUI, Mirage > >>> Reporter: Bram Luyten (@mire) > >>> > >>> Independent on which page you're on, logging in always seems to send > >>> you > >> back to the homepage. In my opinion, it would be nice if you would > >> stay on the page where you were, before logging in. > >> ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1 _______________________________________________ Dspace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-devel
