[
https://jira.duraspace.org/browse/DS-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21663#comment-21663
]
Mark Diggory edited comment on DS-989 at 8/11/11 1:43 PM:
----------------------------------------------------------
>From the comments it is clear that something was missed in the dialog. This
>has nothing to do with interpolation in the ConfigurationManager or
>ConfigurationService and has to do with the Maven build profiles that are used
>but DSpace to configure the values that will be used in the DSpace.cfg from
>the DSpace/pom.xm. What Kevin proposes makes the most sense because it extends
>the current behavior for filtering to apply across all the configurations as
>well as the DSpace.cfg. If you are not understanding the current behavior,
>please review the DSpace/pom.XML prior to responding, we currently support
>filtering the choices of database driver, username and password via build
>profiles located here. When we setup a staging environment for DSpace within
>@mire, we use similar profiles to identify dev, test and prod settings for
>these and many more of the config properties. If we continue on this avenue
>of separating out the config, we should be maintaining a consistent filtering
>process across all the config so that we can maintain this approach. It was
>Graham and I that originally put this into place to support different database
>drivers and build profiles. If we take the stance that we want to eventually
>create "modules/database.cfg" as a module config, then we will need this patch
>Kevin has provided to support the maven filtering.
was (Author: mdiggory):
From the comments it is clear that something was missed in the dialog.
This has nothing to do with interpolation in the ConfigurationManager or
ConfigurationService and has to do with the Maven build profiles that are used
but DSpace to configure the values that will be used in the DSpace.cfg from the
DSpace.cfg. What Kevin proposes makes the most sense because it extends the
current behavior for filtering to apply across all the configurations as well
as the DSpace.cfg. If you are not understanding the current behavior, please
review the DSpace/pom.XML prior to responding, we currently support filtering
the choices of database driver, username and password via build profiles
located here. When we setup a staging environment for DSpace within @mire, we
use similar profiles to identify dev, test and prod settings for these and many
more of the config properties. If we continue on this avenue of separating out
the config, we should be maintaining a consistent filtering process across all
the config so that we can maintain this approach. It was Graham and I that
originally put this into place to support different database drivers and build
profiles. If we take the stance that we want to eventually create
"modules/database.cfg" as a module config, then we will need this patch Kevin
has provided to support the maven filtering.
> Module directory maven property support
> ---------------------------------------
>
> Key: DS-989
> URL: https://jira.duraspace.org/browse/DS-989
> Project: DSpace
> Issue Type: Improvement
> Reporter: Kevin Van de Velde
> Priority: Major
> Attachments: Modules_directory_properties.patch
>
>
> Since it is now possible to use properties in the dspace.cfg file (dspace.dir
> = ${default.dspace.dir}) I have created a patch that also allows these
> properties in the {dspace.dir}/modules directory.
> The patch contains a working example for the solr server, once the following
> patch https://jira.duraspace.org/browse/DS-971 is committed this solr
> property can also be used in the discovery.cfg file. This way users will only
> have one place to put solr server property.
> The maven assembly plugin version had to updated for this to work since the
> beta version used in DSpace doesn't support a file filter for directories
> (http://jira.codehaus.org/browse/MASSEMBLY-154). The version now used is the
> latest stable on for the plugin (source:
> http://jira.codehaus.org/browse/MASSEMBLY).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
user administration capabilities and model configuration. Take
the hassle out of deploying and managing Subversion and the
tools developers use with it.
http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
