Correct, TBH, The critical detail of our standard were not JAVA formatting
specific. I rather care less about where curly brackets are/arn't.
The most important feature of the original requirements was that
"whitespace" be standardized to eliminate windows linefeeds getting into
sourcecode and creating commits of code that have no real semantic change.
Code formatting in Eclipse/IDEA using standard defaults is best. But
historically, our codebase has a mixing of formatting caused by past commits
by developers using terminal clients not wanting to bother with proper
formatting. So our own code doesn't actually adhere wholly to our own
current formatting standards and TBH, going through and reformatting those
sections (or the entire codebase to make it fit the default standard) would
result in such a large number of "non-semantic" line changes, I'm not sure
the benefit outweighs the "merge nightmare" for users that it would create.
Mark
On Tue, Sep 6, 2011 at 11:41 AM, Sands Alden Fish <[email protected]> wrote:
> Mark, just to be clear here, you're suggesting a whole-sale conversion from
> the original DSpace project code formatting standards to the standard ones
> supported by modern IDEs, is that right?
>
> I would second this if that is what you mean. I have never been a fan of
> the old syntax.
>
>
> --
> sands fish
> Senior Software Engineer
> MIT Libraries
> Technology Research & Development
> [email protected]
> E25-131
>
>
>
>
>
> On Aug 24, 2011, at 1:53 PM, Mark Diggory wrote:
>
> We do not have one. TBH, I think we should default to the standard
> java coding conventions that are the defaults in Eclipse and IDEA, it
> would eliminate actually needing any customized files... Note that
> the license headers are managed now in Maven.
>
> Mark
>
> On Tue, Aug 23, 2011 at 1:18 PM, TAYLOR Robin <[email protected]>
> wrote:
>
> Hi all,
>
>
> I notice someone kindly loaded a settings file for Eclipse for the agreed
> coding conventions...
>
>
>
> https://wiki.duraspace.org/display/DSPACE/Code+Contribution+Guidelines#CodeContributionGuidelines-CodingConventions
>
>
> I was wondering if anyone had ever gone to the trouble of creating one for
> Intellij IDEA ? Or if they have their IDE set up to conform to the standards
> if they could possibly export it ? I'm just being lazy, it would save me the
> trouble.
>
>
> Cheers, Robin.
>
>
>
> --
>
> The University of Edinburgh is a charitable body, registered in
>
> Scotland, with registration number SC005336.
>
>
>
>
> ------------------------------------------------------------------------------
>
> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
>
> user administration capabilities and model configuration. Take
>
> the hassle out of deploying and managing Subversion and the
>
> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
>
> _______________________________________________
>
> Dspace-devel mailing list
>
> [email protected]
>
> https://lists.sourceforge.net/lists/listinfo/dspace-devel
>
>
>
>
>
> --
> Mark R. Diggory
> @mire - www.atmire.com
> 2888 Loker Avenue East - Suite 305 - Carlsbad - CA - 92010
> Esperantolaan 4 - Heverlee 3001 - Belgium
>
>
> ------------------------------------------------------------------------------
> EMC VNX: the world's simplest storage, starting under $10K
> The only unified storage solution that offers unified management
> Up to 160% more powerful than alternatives and 25% more efficient.
> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
>
> _______________________________________________
> Dspace-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/dspace-devel
>
>
>
--
Mark R. Diggory
@mire - www.atmire.com
2888 Loker Avenue East - Suite 305 - Carlsbad - CA - 92010
Esperantolaan 4 - Heverlee 3001 - Belgium
------------------------------------------------------------------------------
Malware Security Report: Protecting Your Business, Customers, and the
Bottom Line. Protect your business and customers by understanding the
threat from malware and how it can impact your online business.
http://www.accelacomm.com/jaw/sfnl/114/51427462/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
