[
https://jira.duraspace.org/browse/DS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Donohue updated DS-135:
---------------------------
Attachment: Tim-DS135.patch
In the essence of time, I went ahead and generated a simplified version of
Mark's patch (see Tim-DS135.patch above), removing a few features and
performing minor cleanup.
My version of the tombstone patch has the same implementation as Mark's, but I
changed the following things:
* Access Restricted / Withdrawn pages now return 404 status
* Login link is only displayed if an item is access restricted (not displayed
if withdrawn)
* Added some more message keys to clean up usability (make it more obvious when
something is withdrawn or when you are logged in but still don't have access to
a restricted item)
* Removed the Feedback Form from the tombstone page (it wasn't working properly
& I'm not sure everyone agrees it should be there -- we can always reanalyze
after 1.8)
* Fixed a few minor bugs (e.g. the link to the login page was wrong)
Again, in the essence of time (since 1.8.0 final is pending), I'm going to
commit this simplified patch immediately to Trunk for feedback & further
testing. We can always roll it back if we notice any issues.
> Withdrawn items displayed as "restricted" rather than withdrawn
> ---------------------------------------------------------------
>
> Key: DS-135
> URL: https://jira.duraspace.org/browse/DS-135
> Project: DSpace
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1,
> 1.7.2
> Reporter: Tim Donohue
> Assignee: Robin Taylor
> Priority: Major
> Fix For: 1.8.0
>
> Attachments: Clean_Tombstone_Via_Restricted_Item.patch,
> Tim-DS135.patch, tombstone-screen.jpg
>
>
> If you withdraw an item via the XMLUI, and then visit the item page as a
> non-Admin, you are asked to login. After a valid login, the page displays:
> "You do not have the credentials to access the restricted item
> hdl:123456789/1". This is a misleading message as the item has actually
> been withdrawn and should be displayed as withdrawn.
> If you happen to access a withdrawn item as an Administrator, you are
> displayed the item as normal (with no indication that the item is withdrawn).
> This is also misleading as the Administrator may assume that the item was
> not withdrawn successfully.
> Rather than displaying such a "Restricted Item" message for withdrawn items,
> the following should probably happen:
> (1) User is displayed an "Item has been withdrawn" message
> (2) The page should return a 404, so that search engines are encouraged to
> remove the item from their indexes
> (3) If an Admin accesses a withdrawn item, he/she should see a message that
> clearly states that the item is withdrawn (likely at the top of the page),
> while also seeing the normal metadata/files for the withdrawn item.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
