Mark Diggory commented on Bug DS-1182
This is an important issue that may limit the execution of more than one DSpace instance in a tomcat JVM, it seems sound and I think we could simply shift to use Session.getInstance in a static block of the Email.java class.

Likewise, a Singelton approach is exactly the strategy that the current architectural direction would go in if the ServiceManager were utilized as the mechanism to support EmailServices instead of the ConfigurationManager.getEMail("string") implementation.

In targeting architectural changes to support use of Services, the ConfigurationManager.getEMail("string") and portions of the Email.java internal code should be migrated to be a Service (EmailService) that the application maintainer can easily override with their own implementation. The static methods that exist in the Manager would be retained in the code as convenience methods and reduce the need to migrate all usage at once.

Mark
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to