[
https://jira.duraspace.org/browse/DS-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25729#comment-25729
]
Steve Swinsburg commented on DS-1208:
-------------------------------------
Hi Robin,
Thanks for merging, but the renaming of that file was not the intended function
of this patch. Its actually vital that that does not occur. The reason for this
is that the build.properties.sample file is in source control and shows the
settings that can be used. The build.properties however, must NOT be in source
control as it is local to each environment or node of a cluster and as such
must be kept local. So for each environment, developers take a copy of
build.properties.sample to build.properties and fill in the settings.
I have a patch that I will be submitting on Monday that deals with the build
time notice about the file that needs to be created before building.
Could you revert that commit or should I update and make the changes in a new
commit?
> Build time filtering to allow multi developer/environment builds
> ----------------------------------------------------------------
>
> Key: DS-1208
> URL: https://jira.duraspace.org/browse/DS-1208
> Project: DSpace
> Issue Type: Bug
> Reporter: Steve Swinsburg
> Assignee: Robin Taylor
>
> The addition of properly placeholders in dspace.cfg goes some of the way to
> allowing multiple developers/environments to use the same source tree,
> however not enough properties have been externalised.
> For example,if I had 5 servers, how would I customise this property for each?
> dspace.baseUrl = http://localhost:8080
> In addition, the current setup requires the build to activate a maven
> profile, and supply properties either at build time or from a pom.xml, which
> are then hardcoded.
> This isn't as flexible as it could be, for example by putting all
> configurable properties into a build.properties/filter.properties file and
> keeping that out of source control.
> Then each developer simply customises the properties file with the values for
> their environment, and the build inserts the properties into the relevant
> source files at build time.
> This is a standard maven filtering approach in use by many other projects.
> Note that any number of files can be filtered using this approach.
> References:
> http://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
