[ 
https://jira.duraspace.org/browse/DS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=25769#comment-25769
 ] 

Nestor Oviedo commented on DS-1207:
-----------------------------------

This might be patched simply by checking if a redirect occured before throwing 
the exception, but that seems a little bit ugly.
Maybe the discussion is why an Exception is thrown. The 404 error is a normal 
situation, and the PageNotFoundTransformer handles it by adding some info to 
the DRI's body. When the exception is thrown, all this handling is discarded, 
the exception reaches the <handle-errors> and the corresponding error page is 
displayed.
I understand this exception could help developers to find some wrong links, or 
some strange behaviour (some attack attempt). 
We experienced a lot a PageNotFound errors. Some of them produced by real 
users, and the most of them produced by web bots. As a result, our cocoon logs 
grows incredibly fast, filled mostly with stacktraces ...

Perhaps those 404 errors should be handled differently; for example by adding a 
single logging line to the log file instead of throw an execption and record 
the full stacktrace.

Any thoughts on this ?
Regards
                
> ResourceNotFoundException on redirect
> -------------------------------------
>
>                 Key: DS-1207
>                 URL: https://jira.duraspace.org/browse/DS-1207
>             Project: DSpace
>          Issue Type: Bug
>    Affects Versions: 1.8.2, 3.0
>            Reporter: Nestor Oviedo
>              Labels: ResourceNotFoundException, redirect
>
> When the request is redirected to another URL, the cocoon log shows a 
> ResourceNotFoundException thrown from the 
> org.dspace.app.xmlui.aspect.general.PageNotFoundTransformer transformer 
> (referenced in aspects/aspects.xmap when no aspect matched the URI).
> This transformer checks if the DRI body is empty and then throws the 
> exception, but never checks if it was empty because a redirect ocurred.
> Although this error is never seen by the user, it goes to the log and is very 
> annoying.
> To reproduce this error just get a default dspace installation and go to the 
> /login page. Then check the cocoon log .

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to