[ 
https://jira.duraspace.org/browse/DS-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26135#comment-26135
 ] 

Kostas Stamatis commented on DS-1223:
-------------------------------------

Dear Andrea,

I got your point and made the appropriate changes in the github code (thus, the 
pull request updated accordingly).

However, a point here is that the changes you mentioned work only in the case 
of browsing from the home page of DSpace. When you are inside a community or a 
collection, the trick (with limiting the items of the dis-table) cannot work, 
since, you do not know beforehand if the dis-items that you will limit belong 
to the collection or community you are browsing in. You have to limit at the 
end. Is that true?

So, for documentation purposes, I write down the resulted SQL statements for 
all cases:

1) Browse from home screen (Frequencies disabled):

SELECT bi_2_dis.* FROM bi_2_dis  ORDER BY sort_value ASC  NULLS LAST  LIMIT ?

2) Browse from home screen (Frequencies  enabled):

SELECT  COUNT(*) AS num, distable.value, distable.authority FROM (SELECT 
bi_4_dis.* FROM bi_4_dis ORDER BY sort_value ASC NULLS LAST LIMIT ? ) distable, 
(SELECT bi_4_dmap.distinct_id  FROM bi_4_dmap) mappings  WHERE  
distable.id=mappings.distinct_id  GROUP BY distable.value, distable.authority, 
distable.sort_value ORDER BY sort_value ASC  NULLS LAST

3) Browse within a collection (Frequencies disabled):

SELECT bi_2_dis.* FROM bi_2_dis, (SELECT DISTINCT bi_2_dmap.distinct_id  FROM 
collection2item, bi_2_dmap WHERE bi_2_dmap.item_id=collection2item.item_id AND 
collection2item.collection_id=? ) mappings  WHERE  
bi_2_dis.id=mappings.distinct_id  ORDER BY sort_value ASC  NULLS LAST  LIMIT ?

4) Browse within a collection (Frequencies enabled)

"SELECT  COUNT(*) AS num, bi_4_dis.value, bi_4_dis.authority FROM bi_4_dis, 
(SELECT bi_4_dmap.distinct_id  FROM collection2item, bi_4_dmap WHERE 
bi_4_dmap.item_id=collection2item.item_id AND collection2item.collection_id=? ) 
mappings  WHERE  bi_4_dis.id=mappings.distinct_id  GROUP BY bi_4_dis.value, 
bi_4_dis.authority, bi_4_dis.sort_value ORDER BY sort_value ASC  NULLS LAST  
LIMIT ?
                
> Display frequencies of items in single browsing for selected indices
> --------------------------------------------------------------------
>
>                 Key: DS-1223
>                 URL: https://jira.duraspace.org/browse/DS-1223
>             Project: DSpace
>          Issue Type: Improvement
>          Components: JSPUI
>    Affects Versions: 1.8.2
>            Reporter: Christina Paschou
>              Labels: has-patch, has-pull-request
>         Attachments: browse_frequencies.diff, README.txt
>
>
> DSpace provides by default two types of browsing, naming them single browsing 
> and full browsing according to the corresponding names of the .jsp files that 
> are responsible for handling each request (single.jsp & full.jsp). 
> Each type of browsing is defined accordingly and configured in different way 
> in the configuration file dspace.cfg.  
> The proposed improvement is applied for the case of browsing by a unique 
> index of metadata values from the item (single browsing). In this case, the 
> user can define for each metadata browse index whether he wishes to add next 
> to its various metadata values the frequencies of items that are included. 
> The configuration takes place in the dspace.cfg.
> Examples: 
> http://phdtheses.ekt.gr/eadd/browse?type=subject
> http://phdtheses.ekt.gr/eadd/browse?type=country
> http://phdtheses.ekt.gr/eadd/browse?type=language
> Attached you can find the patch file and a readme file with details about tha 
> configuration that is needed to be made.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to