[
https://jira.duraspace.org/browse/DS-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26139#comment-26139
]
Andrea Bollini commented on DS-1238:
------------------------------------
Hi Kostas,
imho this contribution requires some changes before to be ready for commit to
the master.
1) we should avoid heavy code duplication, most of this jsp comes from the
simple-search result jsp with inclusion of the "form" fragment from the
advanced-search. An appropriate use of inclusion should be able to avoid this
2) the user should be able to switch to the old "onebox" where it can do use of
the full lucene syntax if she wants. Both form: "advanced-search" and
"lucene-syntax" forms should be included in the resulting html page with the
lucene-syntax form hided and activable using javascript (users with javascript
disabled will be able to see and use both)
Andrea
PS: you have a misprint here:
https://github.com/DSpace/DSpace/pull/51/files#L1R54
> Display advance search form after an advance search
> ----------------------------------------------------
>
> Key: DS-1238
> URL: https://jira.duraspace.org/browse/DS-1238
> Project: DSpace
> Issue Type: Improvement
> Components: JSPUI
> Affects Versions: 1.8.2
> Reporter: Kostas Stamatis
> Assignee: Andrea Bollini
> Labels: has-patch, has-pull-request
> Attachments: advancedresults_patch.diff, README.txt
>
>
> This proposed extension (implemented by National Documentation Centre/EKT -
> http://www.ekt.gr) displays the advance search form after an advance search
> in DSpace. The current version of DSpace, returns a simple search form with
> the Lucene query that is not starange for the user. In case the user needs to
> redifine the query, he must change the Lucene query which is not wise at all.
> Given this extension, he can see the advance form filled with the initial
> search parameters and make hiw changes and search again.
> EXAMPLES
> ------------
> Repository: http://phdtheses.ekt.gr/eadd/advanced-search
> Note: Make an advance search and notice that in the results page, the advance
> search form is displayed as well
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
