[
https://jira.duraspace.org/browse/DS-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26143#comment-26143
]
Tim Donohue commented on DS-1227:
---------------------------------
Looking at this code more closely (in Pull #47), there's several issues here
I'm worried about & I'd vote -1 as of now:
1. The 'opencloud' dependency should really be released to Maven. This is a
minor issue though, as we (DSpace committers) could push it out under
'org.dspace.dependencies' as needed.
2. UIUtil class changes have a *hardcoded* email/eperson ([email protected])
https://github.com/DSpace/DSpace/pull/47/files#L4R491
3. UIUtil class changes create/close a brand new Context (is there a reason why
the existing Context cannot be used with the existing EPerson session?)
https://github.com/DSpace/DSpace/pull/47/files#L4R486
4. UIUtil class changes use "c.ignoreAuthorization()" -- this effectively
means the current user may be able to see Items in the tagcloud that normally
they wouldn't be able to see (as ignoreAuthorization gives them temporary Admin
privileges)
https://github.com/DSpace/DSpace/pull/47/files#L4R496
5. There are still two usages of the 'gr.ekt.' package
https://github.com/DSpace/DSpace/pull/47/files#L5R451
https://github.com/DSpace/DSpace/pull/47/files#L6R33
> Tag cloud for any browse index in the home page of DSpace
> ---------------------------------------------------------
>
> Key: DS-1227
> URL: https://jira.duraspace.org/browse/DS-1227
> Project: DSpace
> Issue Type: New Feature
> Components: JSPUI
> Reporter: Kostas Stamatis
> Assignee: Sands Fish
> Labels: has-patch, has-pull-request, tag-cloud
> Attachments: opencloud.jar, README.txt, tagcloud-patch.diff
>
>
> This proposed extension (implemented by National Documentation Centre/EKT -
> http://www.ekt.gr) allows the import of a tag cloud in the homepage of DSpace.
> The tag cloud can include values from any of the browse indices (of metadata
> type) of the repository and this is a configuration option along with many
> other options that you can see later.
> Tha tag cloud is implemented as a tag, meaning that it can be included in any
> page of the DSpace repository besides the homepage.
> USEFULNESS
> ---------------------
> Select a important browse index of your repository (i.e. subject) and include
> all major subjects of your records in the home page of DSpace to attract
> visitors.
> CONFIGURATION FILES
> ---------------------------------------
> Tag cloud is fully configurable within the default dspace.cfg configuration
> file of DSpace. The new configuration options are:
> #######################################################
> # TAG CLOUD configuration #
> #######################################################
> #
> # Should display tag cloud in the home page?
> # Possible values: true | false
> webui.tagcloud.home.show = true
> #
> # Select the browse index to create a tag cloud for in the home page
> # Possible values: any of the browse indices declared earlier in this conf
> file
> webui.tagcloud.home.bindex = subject
> #
> # Select the total tags to show
> # Possible values: any integer from 1 to infinity
> webui.tagcloud.home.maxtags = 50
> #
> # Should display the score next to each tag?
> # Possible values: true | false
> webui.tagcloud.home.showscore = false
> #
> # The score that tags with lower than that will not appear in the rag cloud
> # Possible values: any integer from 1 to infinity
> webui.tagcloud.home.cutlevel = 5
> #
> # Should display the tag as center aligned in the page or left aligned?
> # Possible values: true | false
> webui.tagcloud.home.showcenter = true
> #
> # The font size (in em) for the tag with the lowest score
> # Possible values: any decimal
> webui.tagcloud.home.fontfrom = 1.3
> #
> # The font size (in em) for the tag with the highest score
> # Possible values: any decimal
> webui.tagcloud.home.fontto = 2.8
> #
> # The case of the tags
> # Possible values: Case.LOWER | Case.UPPER | Case.CAPITALIZATION |
> Case.PRESERVE_CASE | Case.CASE_SENSITIVE
> webui.tagcloud.home.tagcase = Case.PRESERVE_CASE
> #
> # If the 3 colors of the tag cloud should be independent of score
> (random=yes) or based on the score
> # Possible values: true | false
> webui.tagcloud.home.randomcolors = true
> #
> # The ordering of the tags (based either on the name or the score of the tag)
> # Possible values: Tag.NameComparatorAsc | Tag.NameComparatorDesc |
> Tag.ScoreComparatorAsc | Tag.ScoreComparatorDesc
> webui.tagcloud.home.tagorder = Tag.NameComparatorAsc
> #
> # The first color of the tags
> # Possible values: hex value of the color (i.e. e3d67a)
> webui.tagcloud.home.tagcolor1 = D96C27
> #
> # The second color of the tags
> # Possible values: hex value of the color (i.e. e3d67a)
> webui.tagcloud.home.tagcolor2 = 424242
> #
> # The third color of the tags
> # Possible values: hex value of the color (i.e. e3d67a)
> webui.tagcloud.home.tagcolor3 = 818183
> EXTERNAL LIBRARIES
> --------------------------------------
> This extension makes use of the following external java library:
> a) opencloud |(http://opencloud.mcavallo.org/): a java library for for
> generating and managing tag clouds (under MIT licence)
> EXAMPLES
> -------------------
> Repository: Managing Authority of the Operational Programme "Education and
> Lifelong Learning"
> URL: http://repository.edulll.gr/edulll/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
