Hi,
The wiki for the pre-DSpace3 has instructions on how to correct yourself.
https://github.com/DSpace/DSpace-SVN-Deprecated/wiki/Fixing-%22missing-dspace-modules-jspui-src-main-webapp-directory%22
I don't like PR#105 (merge commit bringing in hundreds of changes). That
one has already been closed as won't pull.
Doctorland has made another pull-request, that is a single-commit, and
creates 7 new files that makes git track these empty directories. I would
bless/approve this commit.
https://github.com/DSpace/DSpace/pull/107
I do recognize that this affects a previous branch than our latest, but
as-we-speak its our latest stable version of DSpace.
At my University, we based our 1.8 upgrade off of DSpace/DSpace 1.8.x, and
we had to make this same exact correction. Its time consuming, and
annoying, and easily preventable with this PR.
Peter Dietz
On Mon, Oct 22, 2012 at 11:10 AM, João Melo <jm...@lyncode.com> wrote:
> Hi Helix,
>
> as far as 1.8.x version doesn't become obsolete this kind of pulls can
> happen. It's a weird problem for DSpace starters, however, i agree with
> you.
>
> On 19 October 2012 15:02, helix84 <heli...@centrum.sk> wrote:
>
>> Hello, I'm forwarding this here for discussion.
>> It started when we migrated to Git. One thing we overlooked is that
>> Git doesn't manage empty directories. Of you have empty directories
>> and commit them, they won't be there if you clone the repo. The
>> problem in our case is, that maven needs these empty directories, so
>> any old version migrated to Git from SVN won't build until you apply
>> the workaround we documented here:
>>
>>
>> https://wiki.duraspace.org/display/DSPACE/Development+with+Git#DevelopmentwithGit-CommonDSpaceGit/GitHubIssues
>>
>> We cannot fix the Git history now. We announced that the DSpace/DSpace
>> repo on GitHub is official and there have been many forks. If we
>> decided to rewrite the history, all of those forks would have to be
>> thrown away and that's just not viable.
>>
>> Yesterday, Jonathan Harker noticed the problem and sent pull request
>> #105 [1], which was meant to add a commit to the dspace-1_8_x branch,
>> that would fix that if you checked out any later commit. I closed it
>> only for formal problems, not because I disagree with the idea. I'm
>> taking the idea here to discuss.
>>
>> Obviously, this solution isn't systemic and introduces different
>> behaviour. On one hand we'd have working mvn package for all commits
>> after this one. On other hand, we'd still have mvn package throwing
>> and error for the commits before it in this branch and for all commits
>> in the older branches. Status quo is at least consistent and
>> documented. What do you think?
>>
>> [1] https://github.com/DSpace/DSpace/pull/105
>>
>> Regards,
>> ~~helix84
>>
>> On Fri, Oct 19, 2012 at 3:40 PM, Tim Donohue <tdono...@duraspace.org>
>> wrote:
>> > This discussion should probably take place on dspace-devel.
>> >
>> > I'm honestly not sure how many folks this even effects. If it does annoy
>> > several folks, then I agree the effort may be worth it to clean this up
>> in
>> > the branches. But, if most folks don't even encounter this, it may not
>> be
>> > worth the effort.
>> >
>> > I know we did write up the workaround on our Git instructions:
>> >
>> https://wiki.duraspace.org/display/DSPACE/Development+with+Git#DevelopmentwithGit-CommonDSpaceGit/GitHubIssues
>> >
>> > - Tim
>> >
>> >
>> > On 10/19/2012 1:16 AM, helix84 wrote:
>> >>
>> >> Hi Tim,
>> >>
>> >> what do you think of the idea of adding the missing empty directories
>> >> (required to build) to the HEAD of the dspace-1_8_x branch (and
>> >> possibly older branches)?
>> >>
>> >> https://github.com/DSpace/DSpace/pull/105
>> >>
>> >> Obviously, checking out any older commit from the branch would still
>> >> need creating those directories, we can't change that now and it's
>> >> documented. This change would potentialy introduce more confusion,
>> >> becase in a given branch commits after some commit would build
>> >> differently than before it.
>> >>
>> >> Do we want to make this change?
>> >>
>> >> Regards,
>> >> ~~helix84
>> >>
>> >
>>
>>
>> ------------------------------------------------------------------------------
>> Everyone hates slow websites. So do we.
>> Make your web apps faster with AppDynamics
>> Download AppDynamics Lite for free today:
>> http://p.sf.net/sfu/appdyn_sfd2d_oct
>> _______________________________________________
>> Dspace-devel mailing list
>> Dspace-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/dspace-devel
>>
>
>
>
> --
> Thanks, João Melo (My Portfolio <http://www.lyncode.com/m/jmelo/>)
> DSpace Department
> *Lyncode*: Official
> website<http://www.google.com/url?q=http%3A%2F%2Fwww.lyncode.com%2F&sa=D&sntz=1&usg=AFrqEzdV8iS6rMxflxnn138XReuRfUG3OQ>
> [image: Follow us on
> Facebook]<http://www.google.com/url?q=http%3A%2F%2Ftwitter.com%2Flyncode&sa=D&sntz=1&usg=AFrqEzeDuT3ZqMW5uVIA8AoxtTtAeiCX3Q>
> <http://www.google.com/url?q=http%3A%2F%2Fwww.facebook.com%2Flyncode&sa=D&sntz=1&usg=AFrqEzcWXjHa3gKBGLsNVxktapxkiWDnww>
>
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://p.sf.net/sfu/appdyn_sfd2d_oct
> _______________________________________________
> Dspace-devel mailing list
> Dspace-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dspace-devel
>
>
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
