[
https://jira.duraspace.org/browse/DS-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27542#comment-27542
]
Ivan Masár commented on DS-1459:
--------------------------------
I tested your patch and it works great:
dspace.cfg:
crosswalk.dissemination.test.stylesheet = crosswalks/test.xsl
[dspace]/bin/dspace dsrun
org.dspace.content.crosswalk.XSLTDisseminationCrosswalk test 123456789/123
I have some comments:
1) as the first parameter you could also accept path to stylesheet in addition
to configured crosswalk name
2) there should be an optional parameter for output file (yes, I know shell
redirection works just fine)
3) there are some code style conventions you should keep:
https://wiki.duraspace.org/display/DSPACE/Code+Contribution+Guidelines#CodeContributionGuidelines-CodingConventions
4) typos: occured -> occurred, informatin -> information, verbous -> verbose
Thanks.
> Testing of dissemination crosswalks
> -----------------------------------
>
> Key: DS-1459
> URL: https://jira.duraspace.org/browse/DS-1459
> Project: DSpace
> Issue Type: Improvement
> Components: DSpace API
> Affects Versions: 3.0
> Reporter: Pascal-Nicolas Becker
> Original Estimate: 5 hours
> Remaining Estimate: 5 hours
>
> In the wiki it is proposed to use OAI to test new xslt dissemination
> crosswalks. But the new OAI-PMH of DSpace 3.0 does not use DIM as XML to
> transfer with xslt. So a new possibility to test xslt dissemination
> crosswalks is necessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
