Tim Donohue created DS-1540:
-------------------------------

             Summary: DSpace's .gitignore wrongly ignores all *.properties files
                 Key: DS-1540
                 URL: https://jira.duraspace.org/browse/DS-1540
             Project: DSpace
          Issue Type: Bug
    Affects Versions: 3.1, 3.0
            Reporter: Tim Donohue
            Assignee: Tim Donohue
            Priority: Trivial
             Fix For: 3.2, 4.0


DSpace's primary [src]/.gitignore file accidentally ignores all *.properties 
files, at all levels in the codebase.

## Ignore all *.properties file, EXCEPT build.properties (the default)
*.properties
!build.properties

This means that if you are copying DSpace into your own Git repo, Git will 
assume that other *.properties files necessary to run DSpace should not be 
added.  (For example: 
http://www.mail-archive.com/[email protected]/msg21528.html)

The fix is that DSpace's .gitignore should be modified to only ignore 
*.properties files in the *root* (/) source folder. This allows you to still 
create non-version-controlled custom build.properties files (e.g. 
prod.properties, dev.properties), while still ensuring all other *.properties 
files in other subfolders are properly versioned.  

To fix, replace the above .gitignore lines with:

## Ignore all *.properties file in root folder, EXCEPT build.properties (the 
default)
/*.properties
!/build.properties

I'll create a pull request for this fix shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to