On Thu, Sep 19, 2013 at 03:57:47PM +0200, helix84 wrote:
> On Thu, Sep 19, 2013 at 3:23 PM, Anja Le Blanc
> <[email protected]> wrote:
[snip]
> > We are using both Wijiti and Hedtek and are not completely happy with
> > either. For once run a GET on all items on a repository with enough
> > content and your Tomcat can easily run out of memory and die. Not very
> > suitable for a service environment.
> 
> You're one of the few users who worked with both and are able to judge
> which one is better. What we currently care about the most is which
> API is the best to work with, not which implementation. If the problem
> you mentioned is inherent to the API design, the API design should
> change (e.g. adopt resumption tokens like in OAI-PMH).

I think it's far more likely that the code is accumulating a huge
Array, Collection, or String instead of dealing completely with each
element of the ResultSet as it is retrieved.  This seems to be a common
antipattern in Java code.

The first places I would seek the source of the problem behavior are
the treatment of query results and the way in which the
ServletResponse is filled out.  [rummages through Wijiti REST] Yes, I
see several methods which will slurp every affected Item record into
an ArrayList.  Not good if you have referenced 20,000,000 Items.  We
need to comb through the code and turn a lot of Lists into Iterables.

It will be a lot easier to hunt down and fix annoyances like this when
the REST code is integrated into DSpace.  I would rather get usable
code with room for improvement into the field now and begin to winkle
out all of its needs, than to wait for it to spontaneously become
perfect.

-- 
Mark H. Wood, Lead System Programmer   [email protected]
Machines should not be friendly.  Machines should be obedient.

Attachment: signature.asc
Description: Digital signature

------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to