Hi all, I know we've had this discussion before, but all I seem to get is more and more confused about what a "private" item is supposed to mean.
Andrea did a good job previously of trying to define the differences here: https://wiki.duraspace.org/display/~bollini/DSpace+Item+state+definitions But, we have an oddity in the implementation of "private" vs. "withdrawn" item. Essentially *both* of these types of items are effectively withdrawn items. Clicking "Make Private" does the following: 1. sets 'discoverable=false' 2. withdraws the item from the archive https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/java/org/dspace/app/xmlui/aspect/administrative/FlowItemUtils.java#L329 The odd thing is that withdrawing an item already makes it no longer visible/findable (what is "discoverable=false" even adding?). So, why do we have this new "make private" option anyways? It's also worth noting that withdrawing an item removes it from the "in_archive" state, which means the item is no longer being checked by things like the Checksum checker (and can no longer be processed by things like Curation Tasks, since they only operate on "in_archive" Items, as Collection.getItems() only returns that) https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/content/Item.java#L1866 Conclusion: Private items are no longer "in_archive", and therefore are not really being preserved/maintained in the same way as a normal item. They are ignored by the Checksum Checker, by Curation Tasks, and likely other things. Is it just me, or does this sound like a major bug in how 'private' items are being handled? Or maybe I'm still just confused here? - Tim -- Tim Donohue Technical Lead for DSpace & DSpaceDirect DuraSpace.org | DSpace.org | DSpaceDirect.org ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel
