Title: Message Title
|
|
|
|
OK, I made much bigger effort than I should trying to even prepare this for review. Roughly in order of importance - the patches are in almost unusable format (use "diff -u" on the whole codebase, or "git diff"), there is at least one missing class (InputStreamDataSource2), misses required license headers (see any java file), doesn't correspond to required code style (see https://wiki.duraspace.org/display/DSPACE/Code+Contribution+Guidelines ), inconsistent email template file names (change requestItem.admin to request_item_admin etc). And what about the class names ending in "2"? Can't they have a normal name?
So I didn't even get to reviewing it. Try fixing these things. The deadline I have for merging this code (after review) is Monday.
|
|
|
|
|
|
|
The University of Minho developed a patch that gives this functionality in JSPUI: https://wiki.duraspace.org/display/DSPACE/RequestCopy .
In implementing it for the XMLUI, I would like to alter the functionality so that the process looks something like:
a. User clicks on restricted item link
b. System responds with current behavior, adding a l...
|
|
|
|
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
