Title: Message Title
|
|
|
|
|
Issue Type:
|
![Bug]() Bug
|
|
Affects Versions:
|
3.2, 4.0
|
|
Assignee:
|
Unassigned
|
|
Components:
|
DSpace API
|
|
Created:
|
12/Nov/13 11:06 AM
|
|
Fix Versions:
|
4.0
|
|
Labels:
|
ldap authentication has-pull-request
|
|
Priority:
|
![Minor]() Minor
|
|
Reporter:
|
Ivan Masár
|
|
Reported by email by rlseaton: http://dspace.2283337.n4.nabble.com/DSpace-LDAP-authentication-problem-tp4665853p4668861.html
I was having the same problem with the "null" string appearing and helix84's fix worked in 3.2.
However, I wanted to let you know that the way the conditionals are set up in the fixed LDAPAuthentication.java file makes it so that LDAP authentication never uses the email_field specified in authentication-ldap.cfg if it's available.
I simply replaced this (~line 255):
if ((StringUtils.isEmpty(email)) &&
(StringUtils.isNotEmpty(ConfigurationManager.getProperty("authentication-ldap", "netid_email_domain"))))
{
email = netid + ConfigurationManager.getProperty("authentication-ldap", "netid_email_domain");
}
else
{
email = netid;
}
with this:
if (StringUtils.isEmpty(email))
{
if((StringUtils.isNotEmpty(ConfigurationManager.getProperty("authentication-ldap", "netid_email_domain"))))
{
email = netid + ConfigurationManager.getProperty("authentication-ldap", "netid_email_domain");
}
else
{
email = netid;
}
}
And that fixed the problem.
Now when new users are auto-registered via LDAP, if the email string isn't empty it will correctly use it instead of replacing it with only the netid.
|
|
|
|
|
|
|
|
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
