Title: Message Title
|
|
|
|
|
Issue Type:
|
![Bug]() Bug
|
|
Affects Versions:
|
4.0, 3.2
|
|
Assignee:
|
Unassigned
|
|
Components:
|
XMLUI
|
|
Created:
|
30/Jan/14 4:46 PM
|
|
Priority:
|
![Minor]() Minor
|
|
Reporter:
|
Tim Donohue
|
|
Initially reported in this thread:
http://dspace.2283337.n4.nabble.com/More-enterprise-deployment-questions-td4670528.html
The DSpace XMLUI seems to respond with a 500 response (rather than a proper 404) for some invalid paths which begin with "/static".
It only seems to occur for URLs of this format:
[dspace-xmlui-url]/static/*/*.js
[dspace-xmlui-url]/static/*/*.css
[dspace-xmlui-url]/static/*/*.json
In other words, the XMLUI path must start with "/static/", and it must end with either ".js", ".css" or ".json". So, it's a very specific URL structure that throws this 500 response (all others will return 404 responses).
The underlying error IS BENIGN. Essentially, what is going on here is that we have some special processing to allow institutions to easily add custom _javascript_ or CSS files to their themes. Those custom files become available on the "/static" path. See this line in the sitemap.xmap:
https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/webapp/sitemap.xmap#L645
Currently, if someone attempts to reference a .js/.css/.json file which does NOT exist, DSpace code is unfortunately is throwing a Java NullPointerException (as it's failing to check if the requested file actually exists). Here's the line where the NullPointerException is thrown:
https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/java/org/dspace/app/xmlui/cocoon/ConcatenationReader.java#L174
While this error is annoying, and the 500 response is incorrect, it is benign. No _javascript_ is being executed by DSpace. It's just an error where the underlying Java code is not checking for a possible "null" result (which only occurs when the requested *.js/*.css/*.json file is not found).
|
|
|
|
|
|
|
|
------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
