Hi Tim,

while creating a fix for DS-1990 I noticed that the 
VersionedHandleIdentifierProvider was loaded even it was not configured in the 
first location you mentioned. I found it configured as bean for the 
IdentifierProvider in the second location. For a test I deactivated it there 
and run into an exception, as Spring was unable to find any acceptable bean of 
type IdentifierProvider for the IdentifierService and was unable to initialize 
the IdentifierService. I did not had the time to further investigate it, but I 
thought, that the second location you mentioned, is used to provide a minimal 
configuration for Spring and that the first one overrides the second one. But 
please be warned, that this is a guess only...

Regards,
  Pascal


________________________________________
Von: Tim Donohue <tdono...@duraspace.org>
Gesendet: Donnerstag, 29. Mai 2014 18:26
An: dspace-devel
Betreff: [Dspace-devel] Duplication of Spring Configs in codebase?

Hi Developers,

Maybe I'm completely missing the reason, but it looks like we have
similar, duplicative Spring configurations in two areas of the DSpace
4.x codebase:

Location #1: [src]/dspace/config/spring/api/

https://github.com/DSpace/DSpace/tree/master/dspace/config/spring/api


Location #2: [src]/dspace-api/src/main/resources/spring/

https://github.com/DSpace/DSpace/tree/master/dspace-api/src/main/resources/spring

It looks like, based on recent Documentation (e.g. 4.x Discovery docs
[a]), that the primary Spring configs are in Location #1. But, why do we
still have duplicates hanging around in Location #2? Should they be removed?

- Tim

[a] https://wiki.duraspace.org/display/DSDOC4x/Discovery

--
Tim Donohue
Technical Lead for DSpace & DSpaceDirect
DuraSpace.org | DSpace.org | DSpaceDirect.org

------------------------------------------------------------------------------
Time is money. Stop wasting it! Get your web API in 5 minutes.
www.restlet.com/download
http://p.sf.net/sfu/restlet
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel

------------------------------------------------------------------------------
Time is money. Stop wasting it! Get your web API in 5 minutes.
www.restlet.com/download
http://p.sf.net/sfu/restlet
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to