Title: Message Title
|
|
|
|
|
Issue Type:
|
![Bug]() Bug
|
|
Affects Versions:
|
4.1, 5.0
|
|
Assignee:
|
Unassigned
|
|
Created:
|
24/Jun/14 5:22 PM
|
|
Priority:
|
![Minor]() Minor
|
|
Reporter:
|
Hardy Pottinger
|
|
We discovered this by chance, a repository admin had the misfortune of attempting to work on our repository (mapping an item from one collection to another), at the same time the repository was being crawled by a web spider. The crossmap attempt consumes an additional 400MB of Eden PS space for about 20 seconds (monitored via Yourkit during a later successful crossmap attempt). The crossmap failed due to running out of available memory.
Looking at the crossmap code, I can see what is likely consuming that memory:
https://github.com/DSpace/DSpace/blob/03276502d60b2644c0c2e6e1ace8846eb6cd5bf5/dspace-xmlui/src/main/java/org/dspace/app/xmlui/aspect/administrative/mapper/MapperMain.java#L126
collection.getItems is called, so that the number of items can be counted, and divided into "native" and "import" counts.
There is probably a less intensive way to gather this data. Perhaps the collection class could get a new method to just inspect the database and report back the needed information? There are probably other examples of this "give me everything so I can count it" approach in the code base... but, since this one has bugged me recently, I suggest we fix it now.
Of course, the quick and dirty "fix" for this is to allocate more heap memory to our repository. I'll do this. But, the "right" solution is to fix this code so it doesn't use as much memory.
|
|
|
|
|
|
|
|
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
