Hi Jonathan, I suspect the reason is simply that we want the change in Solr to happen *immediately* rather than waiting for the next autocommit.
By default, our Solr "auto-commit" settings are defaulted to 10,000 docs or 10 seconds: https://github.com/DSpace/DSpace/blob/master/dspace/solr/search/conf/solrconfig.xml#L370 If we waited on autocommit, there may be a chance that you could delete a Community, and that Community would *still exist* for another 10 seconds in your browse screens before it disappeared. Again, I don't know this all for certain (as I didn't write this area of the code), but that'd be my best guess. Essentially we don't want users to get confused by having objects still appear in Solr Browse/Search results after being deleted. So, instead, we force the commit to happen immediately (thus clearing it from Solr immediately). If you can think of a better way to accomplish this same thing (or avoid that warning), I'm sure we'd love tweaks/patches! Feel free to send us a Pull Request if you have ideas of how to do this better. Thanks, Tim On 7/5/2014 1:55 PM, Jonathan Blood wrote: > > Hi all, When I delete a community, collection or an item in DSpace I > notice the following warning in the Solr logs: > PERFORMANCE WARNING: Overlapping onDeckSearchers=2 > > I went through the code and found this happens at the following line > https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/discovery/IndexEventConsumer.java#L184 > indexer.unIndexContent(ctx, hdl, true); > > A description of the method parameters can be found here > https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/discovery/SolrServiceImpl.java#L275 > Is there a particular reason why we would force a commit here rather than > letting auto commit handle > this? Regards, Jonathan ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ DSpace-tech mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-tech List Etiquette: https://wiki.duraspace.org/display/DSPACE/Mailing+List+Etiquette
