Jose, Not sure what the issue is. But this PR was against master at some point, which might be different than your current branch, so there could be some other semi-relevant changes that you are missing. Also, this PR's commit activity shows something weird of commits reverting commits. You might need to investigate that.
One doesn't usually use the word patch when using GitHub. Though, you can obtain the "patch", by appending ".patch" to the pull request. https://github.com/DSpace/DSpace/pull/999.patch There is also cherry-picking, and there is no way to cherry-pick a PR, but instead you have to cherry-pick commits. This PR has some weird history of it, as there are three commits, which one reverts things... Maybe you need all three commits ? Something like: git cherry-pick b7727a0 git cherry-pick 5010d7f git cherry-pick 88ed31d I would also compare your current file with: https://github.com/christian-scheible/DSpace/blob/88ed31d1470049cfd325b9fb7298f3d9aa1802fb/dspace-api/src/main/java/org/dspace/app/util/GoogleMetadata.java (diff, diffmerge, meld, ...) And/or open your GoogleMetadata.java in an IDE to help determine missing imports. ________________ Peter Dietz Longsight www.longsight.com [email protected] p: 740-599-5005 x809 On Thu, Jun 9, 2016 at 2:43 PM, Jose Blanco <[email protected]> wrote: > I'm still stuck on this one. I wonder what happens with the code in > dspace-api? GoogleMetadata.java is there. I keep thinking that something > needs to be cleared. > > -Jose > > On Wed, Jun 8, 2016 at 2:21 PM, Jose Blanco <[email protected]> wrote: > >> I wonder if I have to clear the java memory? It seems like it's looking >> for Set when it should be looking for Collection? >> >> On Wed, Jun 8, 2016 at 2:00 PM, Jose Blanco <[email protected]> wrote: >> >>> I'm working on incorporating this patch: >>> >>> https://github.com/DSpace/DSpace/pull/999 >>> >>> I changed the file indicated in the patch in my development environment, >>> then I did a build and update, and I was getting this error: >>> >>> 2016-06-07 10:31:12,110 ERROR >>> org.dspace.app.xmlui.cocoon.DSpaceCocoonServletFilter @ Serious Error >>> Occurred Processing Request! >>> >>> org.springframework.web.util.NestedServletException: Handler processing >>> failed; nested exception is java.lang.NoSuchMethodError: >>> org.dspace.app.util.GoogleMetadata.getMappings()Ljava/util/Set; >>> >>> >>> which I think originated from: >>> >>> Caused by: java.lang.NoSuchMethodError: >>> org.dspace.app.util.GoogleMetadata.getMappings()Ljava/util/Set; >>> >>> at >>> org.dspace.app.xmlui.aspect.artifactbrowser.ItemViewer.addPageMeta(ItemViewer.java:329) >>> >>> >>> I was uncertain whether I had to change anything else, other than the >>> file indicated on the PR, but Tim assured me that was it, so I did a >>> rebuild just to try it again and then the error went away and it's working >>> great. Today I went to release the prod with the same code and I'm getting >>> the same error I was initially getting. I'm confused why it did not work. >>> I guess if I knew why it did not work the after the 1st built, and then it >>> worked in dev, I would have a better handle on the problem. Any guesses? >>> >>> >>> Thank you! Jose >>> >> >> > -- > You received this message because you are subscribed to the Google Groups > "DSpace Technical Support" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/dspace-tech. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "DSpace Technical Support" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/dspace-tech. For more options, visit https://groups.google.com/d/optout.
